Refactor namespaces to modules #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tangentially related to #12, a lot of places (example here and here) say not to use namespaces for organizational reasons. Instead, they say use modules and re-export where necessary. In other words, instead of something like this:
Just put the code in a separate file and re-export it like this:
At least, that's my interpretation. Functionally, this makes very little difference to our package (no changes necessary to the prototype). The PR is mostly just splitting code into separate files.